VPN server failure recovery pixels + reasserting fix #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
changed the base branch from
main
to
graeme/vpn-server-failure-recovery-retry-logic
graeme
changed the base branch from
graeme/vpn-server-failure-recovery-retry-logic
to
main
graeme
changed the base branch from
main
to
graeme/vpn-server-failure-recovery-retry-logic
graeme
force-pushed
the
graeme/vpn-server-failure-recovery-retry-logic
branch
from
9e2c20e
to
cb69e94
Compare
graeme
force-pushed
the
graeme/vpn-server-failure-recovery-pixels
branch
from
f448f67
to
eb466b4
Compare
6 tasks
graeme
force-pushed
the
graeme/vpn-server-failure-recovery-pixels
branch
from
eb466b4
to
d4338ca
Compare
graeme
commented
Apr 24, 2024
| @@ -846,8 +847,7 @@ open class PacketTunnelProvider: NEPacketTunnelProvider { | |||
| // MARK: - App Messages | |||
|
|
|||
| // swiftlint:disable:next cyclomatic_complexity | |||
| @MainActor | |||
| public override func handleAppMessage(_ messageData: Data, completionHandler: ((Data?) -> Void)? = nil) { | |||
| @MainActor public override func handleAppMessage(_ messageData: Data, completionHandler: ((Data?) -> Void)? = nil) { | |||
There was a problem hiding this comment.
The annotation line was confusing swiftlint
graeme
changed the title
graeme
commented
Apr 24, 2024
| @@ -53,17 +63,21 @@ actor FailureRecoveryHandler: FailureRecoveryHandling { | |||
| } | |||
|
|
|||
| private let deviceManager: NetworkProtectionDeviceManagement | |||
| private weak var reassertingControl: Reasserting? | |||
There was a problem hiding this comment.
I added the reasserting control to a. Invert control and improve testability and b. To fix an issue where reconnection wouldn’t happen if there was no update to the config
|
@quanganhdo This has all been merged into #786 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required:
Task/Issue URL: https://app.asana.com/0/0/1206939413299475/f
iOS PR: duckduckgo/iOS#2779
macOS PR: https://github.com/duckduckgo/macos-browser/pull/2657
What kind of version bump will this require?: Major
Description:
Adds Pixels described in the task to monitor how often VPN server failure recovery is happening and succeeding.
Steps to test this PR:
OS Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template