BSK support for FB CTL update #760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ladamski
force-pushed
the
la/clicktoload-redux
branch
from
0402bab
to
a4ec422
Compare
ladamski
changed the title
ladamski
commented
Apr 19, 2024
| @@ -221,7 +221,7 @@ fileprivate extension KnownTracker.Rule { | |||
| private extension KnownTracker.ActionType { | |||
|
|
|||
| func toTrackerResolverRuleAction() -> TrackerResolver.RuleAction { | |||
| self == .block ? .blockRequest : .allowRequest | |||
| self == .block || self == .blockCtlFB ? .blockRequest : .allowRequest | |||
There was a problem hiding this comment.
What about line 209 above? We might also need to address the custom action here?
ladamski
force-pushed
the
la/clicktoload-redux
branch
from
20e59fa
to
717db16
Compare
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
|
This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/72649045549333/1205105078450227/f
iOS PR: TBD (hopefully N/A)
macOS PR: https://github.com/duckduckgo/macos-browser/pull/2162
What kind of version bump will this require?: Major/Minor/Patch
Optional:
Tech Design URL: https://app.asana.com/0/1201720254973470/1206422390411022/f
CC:
Description:
Updates BSK to support separate clickToLoad rule list, with associated surrogates changes. CTL is disabled for iOS
Steps to test this PR:
1.
1.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template