Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate export bookmarks file on overwrite #4371

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Truncate export bookmarks file on overwrite #4371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ved-sites-impl/src/main/java/com/duckduckgo/savedsites/impl/service/SavedSitesExporter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ class RealSavedSitesExporter(
if (content.isEmpty()) {
return ExportSavedSitesResult.NoSavedSitesExported
}
val file = contentResolver.openFileDescriptor(uri, "w")
// "w" mode does not truncate on Android 10/11, use "rwt" mode workaround - https://issuetracker.google.com/issues/180526528
val file = contentResolver.openFileDescriptor(uri, "rwt")
if (file != null) {
val fileOutputStream = FileOutputStream(file.fileDescriptor)
fileOutputStream.write(content.toByteArray())
Expand Down