Fix -> showOverFlowMenu by clicking on the iconButton not the whole h… #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nalcalag can you take a look at this? |
|
@MathRoda thank you for your contribution. Unfortunately, we will not be merging it because the requirement from product was to have the entire item tappable for displaying the overflow menu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: #3139
Description :
This PR resolves the issue of clicking at any point of the Manage sites header in Site Permissions screen to show over flow menu.
Steps to test this PR
the over flow menu is only shown if the icon button is clicked
UI changes
Untitled.1.mp4