Update copy when deleting passwords to consider whether sync enabled …

…or not

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/ui/credential/management/viewing/AutofillManagementCredentialsMode.kt

@@ -104,6 +104,9 @@ class AutofillManagementCredentialsMode : DuckDuckGoFragment(R.layout.fragment_a
     @Inject
     lateinit var browserNav: BrowserNav
 
+    @Inject
+    lateinit var stringBuilder: AutofillManagementStringBuilder
+
     // we need to revert the toolbar title when this fragment is destroyed, so will track its initial value
     private var initialActionBarTitle: String? = null
 
@@ -176,21 +179,28 @@ class AutofillManagementCredentialsMode : DuckDuckGoFragment(R.layout.fragment_a
 
     private fun launchDeleteLoginConfirmationDialog() {
         this.context?.let {
-            TextAlertDialogBuilder(it)
-                .setTitle(R.string.autofillDeleteLoginDialogTitle)
-                .setMessage(R.string.credentialManagementDeletePasswordConfirmationMessage)
-                .setDestructiveButtons(true)
-                .setPositiveButton(R.string.autofillDeleteLoginDialogDelete)
-                .setNegativeButton(R.string.autofillDeleteLoginDialogCancel)
-                .addEventListener(
-                    object : TextAlertDialogBuilder.EventListener() {
-                        override fun onPositiveButtonClicked() {
-                            viewModel.onDeleteCurrentCredentials()
-                            viewModel.onExitCredentialMode()
-                        }
-                    },
-                )
-                .show()
+            lifecycleScope.launch(dispatchers.io()) {
+                val dialogTitle = stringBuilder.stringForDeletePasswordDialogConfirmationTitle(numberToDelete = 1)
+                val dialogMessage = stringBuilder.stringForDeletePasswordDialogConfirmationMessage(numberToDelete = 1)
+
+                withContext(dispatchers.main()) {
+                    TextAlertDialogBuilder(it)
+                        .setTitle(dialogTitle)
+                        .setMessage(dialogMessage)
+                        .setDestructiveButtons(true)
+                        .setPositiveButton(R.string.autofillDeleteLoginDialogDelete)
+                        .setNegativeButton(R.string.autofillDeleteLoginDialogCancel)
+                        .addEventListener(
+                            object : TextAlertDialogBuilder.EventListener() {
+                                override fun onPositiveButtonClicked() {
+                                    viewModel.onDeleteCurrentCredentials()
+                                    viewModel.onExitCredentialMode()
+                                }
+                            },
+                        )
+                        .show()
+                }
+            }
         }
     }
 

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/ui/credential/management/viewing/AutofillManagementListMode.kt

@@ -66,6 +66,7 @@ import com.duckduckgo.di.scopes.FragmentScope
 import com.duckduckgo.mobile.android.R as CommonR
 import javax.inject.Inject
 import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
 
 @InjectWith(FragmentScope::class)
 class AutofillManagementListMode : DuckDuckGoFragment(R.layout.fragment_autofill_management_list_mode) {
@@ -94,6 +95,9 @@ class AutofillManagementListMode : DuckDuckGoFragment(R.layout.fragment_autofill
     @Inject
     lateinit var deviceAuthenticator: DeviceAuthenticator
 
+    @Inject
+    lateinit var stringBuilder: AutofillManagementStringBuilder
+
     val viewModel by lazy {
         ViewModelProvider(requireActivity(), viewModelFactory)[AutofillSettingsViewModel::class.java]
     }
@@ -319,61 +323,54 @@ class AutofillManagementListMode : DuckDuckGoFragment(R.layout.fragment_autofill
 
     private fun launchDeleteLoginConfirmationDialog(loginCredentials: LoginCredentials) {
         this.context?.let {
-            TextAlertDialogBuilder(it)
-                .setTitle(R.string.autofillDeleteLoginDialogTitle)
-                .setMessage(R.string.credentialManagementDeletePasswordConfirmationMessage)
-                .setDestructiveButtons(true)
-                .setPositiveButton(R.string.autofillDeleteLoginDialogDelete)
-                .setNegativeButton(R.string.autofillDeleteLoginDialogCancel)
-                .addEventListener(
-                    object : TextAlertDialogBuilder.EventListener() {
-                        override fun onPositiveButtonClicked() {
-                            viewModel.onDeleteCredentials(loginCredentials)
-                        }
-                    },
-                )
-                .show()
+            lifecycleScope.launch(dispatchers.io()) {
+                val dialogTitle = stringBuilder.stringForDeletePasswordDialogConfirmationTitle(numberToDelete = 1)
+                val dialogMessage = stringBuilder.stringForDeletePasswordDialogConfirmationMessage(numberToDelete = 1)
+
+                withContext(dispatchers.main()) {
+                    TextAlertDialogBuilder(it)
+                        .setTitle(dialogTitle)
+                        .setMessage(dialogMessage)
+                        .setDestructiveButtons(true)
+                        .setPositiveButton(R.string.autofillDeleteLoginDialogDelete)
+                        .setNegativeButton(R.string.autofillDeleteLoginDialogCancel)
+                        .addEventListener(
+                            object : TextAlertDialogBuilder.EventListener() {
+                                override fun onPositiveButtonClicked() {
+                                    viewModel.onDeleteCredentials(loginCredentials)
+                                }
+                            },
+                        )
+                        .show()
+                }
+            }
         }
     }
 
     private fun launchDeleteAllLoginsConfirmationDialog(numberToDelete: Int) {
-        val displayStrings = getDisplayStringsForDeletingAllLogins(numberToDelete)
-
         this.context?.let {
-            TextAlertDialogBuilder(it)
-                .setTitle(displayStrings.first)
-                .setMessage(displayStrings.second)
-                .setDestructiveButtons(true)
-                .setPositiveButton(R.string.autofillDeleteLoginDialogDelete)
-                .setNegativeButton(R.string.autofillDeleteLoginDialogCancel)
-                .setCancellable(true)
-                .addEventListener(
-                    object : TextAlertDialogBuilder.EventListener() {
-                        override fun onPositiveButtonClicked() {
-                            viewModel.onDeleteAllPasswordsConfirmed()
-                        }
-                    },
-                )
-                .show()
-        }
-    }
-
-    /**
-     * Returns a pair of strings for the title and message of the delete all logins confirmation dialog.
-     *
-     * The strings will change depending on if there is only one login to delete or multiple.
-     */
-    private fun getDisplayStringsForDeletingAllLogins(numberToDelete: Int): Pair<String, String> {
-        return if (numberToDelete == 1) {
-            Pair(
-                getString(R.string.autofillDeleteLoginDialogTitle),
-                getString(R.string.credentialManagementDeletePasswordConfirmationMessage),
-            )
-        } else {
-            Pair(
-                resources.getQuantityString(R.plurals.credentialManagementDeleteAllPasswordsConfirmationTitle, numberToDelete, numberToDelete),
-                getString(R.string.credentialManagementDeleteAllPasswordsConfirmationMessage),
-            )
+            lifecycleScope.launch(dispatchers.io()) {
+                val dialogTitle = stringBuilder.stringForDeletePasswordDialogConfirmationTitle(numberToDelete)
+                val dialogMessage = stringBuilder.stringForDeletePasswordDialogConfirmationMessage(numberToDelete)
+
+                withContext(dispatchers.main()) {
+                    TextAlertDialogBuilder(it)
+                        .setTitle(dialogTitle)
+                        .setMessage(dialogMessage)
+                        .setDestructiveButtons(true)
+                        .setPositiveButton(R.string.autofillDeleteLoginDialogDelete)
+                        .setNegativeButton(R.string.autofillDeleteLoginDialogCancel)
+                        .setCancellable(true)
+                        .addEventListener(
+                            object : TextAlertDialogBuilder.EventListener() {
+                                override fun onPositiveButtonClicked() {
+                                    viewModel.onDeleteAllPasswordsConfirmed()
+                                }
+                            },
+                        )
+                        .show()
+                }
+            }
         }
     }
 

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/ui/credential/management/viewing/AutofillManagementStringBuilder.kt

@@ -0,0 +1,65 @@
+/*
+ * Copyright (c) 2024 DuckDuckGo
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.duckduckgo.autofill.impl.ui.credential.management.viewing
+
+import android.content.Context
+import android.content.res.Resources
+import com.duckduckgo.autofill.impl.R
+import com.duckduckgo.common.utils.DispatcherProvider
+import com.duckduckgo.di.scopes.FragmentScope
+import com.duckduckgo.sync.api.DeviceSyncState
+import com.squareup.anvil.annotations.ContributesBinding
+import javax.inject.Inject
+import kotlinx.coroutines.withContext
+
+interface AutofillManagementStringBuilder {
+    fun stringForDeletePasswordDialogConfirmationTitle(numberToDelete: Int): String
+    suspend fun stringForDeletePasswordDialogConfirmationMessage(numberToDelete: Int): String
+}
+
+@ContributesBinding(FragmentScope::class)
+class AutofillManagementStringBuilderImpl @Inject constructor(
+    private val context: Context,
+    private val deviceSyncState: DeviceSyncState,
+    private val dispatchers: DispatcherProvider,
+) : AutofillManagementStringBuilder {
+
+    override fun stringForDeletePasswordDialogConfirmationTitle(numberToDelete: Int): String {
+        return context.resources.getQuantityString(
+            R.plurals.credentialManagementDeleteAllPasswordsDialogConfirmationTitle,
+            numberToDelete,
+            numberToDelete,
+        )
+    }
+
+    override suspend fun stringForDeletePasswordDialogConfirmationMessage(numberToDelete: Int): String {
+        val firstMessage = context.resources.deleteAllPasswordsWarning(numberToDelete)
+        val secondMessage = context.resources.getQuantityString(R.plurals.credentialManagementDeleteAllSecondInstruction, numberToDelete)
+        return "$firstMessage $secondMessage"
+    }
+
+    private suspend fun Resources.deleteAllPasswordsWarning(numberToDelete: Int): String {
+        return withContext(dispatchers.io()) {
+            val stringResId = if (deviceSyncState.isUserSignedInOnDevice()) {
+                R.plurals.credentialManagementDeleteAllPasswordsFirstInstructionSynced
+            } else {
+                R.plurals.credentialManagementDeleteAllPasswordsDialogFirstInstructionNotSynced
+            }
+            return@withContext getQuantityString(stringResId, numberToDelete)
+        }
+    }
+}

autofill/autofill-impl/src/main/res/values-bg/strings-autofill-impl.xml

@@ -120,7 +120,6 @@
     <string name="saveLoginDialogSubtitle">Паролите се съхраняват сигурно на Вашето устройство.</string>
     <string name="autofillManagementAddLogin">Добавяне на парола</string>
     <string name="credentialManagementEditLoginTitleHint">Заглавие</string>
-    <string name="autofillDeleteLoginDialogTitle">Сигурни ли сте, че искате да изтриете тази парола?</string>
     <string name="autofillManagementDeletedConfirmation">Паролата е изтрита</string>
     <string name="credentialManagementEditLastUpdated" instruction="Placeholder is a date">Последна актуализация %1$s</string>
     <string name="autofillDisableAutofillPromptTitle">Искате ли да продължите да запазвате пароли?</string>
@@ -149,9 +148,6 @@
         <item quantity="other">Сигурни ли сте, че искате да изтриете %1$d пароли?</item>
     </plurals>
 
-    <string name="credentialManagementDeletePasswordConfirmationMessage">Вашата парола ще бъде изтрита от всички синхронизирани устройства. Уверете се, че все още имате друг начин за достъп до акаунта си.</string>
-    <string name="credentialManagementDeleteAllPasswordsConfirmationMessage">Вашите пароли ще бъдат изтрити от всички синхронизирани устройства. Уверете се, че все още имате друг начин за достъп до Вашите акаунти.</string>
-
     <plurals name="credentialManagementDeleteAllPasswordsSnackbarConfirmation" instruction="Placeholder is a number representing how many passwords were deleted">
         <item quantity="one">%1$d изтрита парола</item>
         <item quantity="other">%1$d изтрити пароли</item>

autofill/autofill-impl/src/main/res/values-cs/strings-autofill-impl.xml

@@ -120,7 +120,6 @@
     <string name="saveLoginDialogSubtitle">Hesla se bezpečně ukládají do tvého zařízení.</string>
     <string name="autofillManagementAddLogin">Přidat heslo</string>
     <string name="credentialManagementEditLoginTitleHint">Název</string>
-    <string name="autofillDeleteLoginDialogTitle">Opravdu chceš smazat tohle heslo?</string>
     <string name="autofillManagementDeletedConfirmation">Heslo smazáno</string>
     <string name="credentialManagementEditLastUpdated" instruction="Placeholder is a date">Poslední aktualizace %1$s</string>
     <string name="autofillDisableAutofillPromptTitle">Chceš dál ukládat hesla?</string>
@@ -151,9 +150,6 @@
         <item quantity="other">Opravdu chceš smazat %1$d hesel?</item>
     </plurals>
 
-    <string name="credentialManagementDeletePasswordConfirmationMessage">Tvoje heslo se smaže ze všech synchronizovaných zařízení. Zkontroluj si předtím, že se i tak dostaneš ke svému účtu.</string>
-    <string name="credentialManagementDeleteAllPasswordsConfirmationMessage">Tvoje hesla se smažou ze všech synchronizovaných zařízení. Zkontroluj si předtím, že se k účtům i tak dostaneš.</string>
-
     <plurals name="credentialManagementDeleteAllPasswordsSnackbarConfirmation" instruction="Placeholder is a number representing how many passwords were deleted">
         <item quantity="one">%1$d smazané heslo</item>
         <item quantity="few">%1$d smazaná hesla</item>

autofill/autofill-impl/src/main/res/values-da/strings-autofill-impl.xml

@@ -120,7 +120,6 @@
     <string name="saveLoginDialogSubtitle">Adgangskoder gemmes sikkert på din enhed.</string>
     <string name="autofillManagementAddLogin">Tilføj adgangskode</string>
     <string name="credentialManagementEditLoginTitleHint">Titel</string>
-    <string name="autofillDeleteLoginDialogTitle">Er du sikker på, at du vil slette denne adgangskode?</string>
     <string name="autofillManagementDeletedConfirmation">Adgangskode slettet</string>
     <string name="credentialManagementEditLastUpdated" instruction="Placeholder is a date">Sidst opdateret %1$s</string>
     <string name="autofillDisableAutofillPromptTitle">Vil du fortsætte med at gemme adgangskoder?</string>
@@ -149,9 +148,6 @@
         <item quantity="other">Er du sikker på, at du vil slette %1$d adgangskoder?</item>
     </plurals>
 
-    <string name="credentialManagementDeletePasswordConfirmationMessage">Din adgangskode slettes fra alle synkroniserede enheder. Husk at sikre, at du stadig har adgang til din konto.</string>
-    <string name="credentialManagementDeleteAllPasswordsConfirmationMessage">Dine adgangskoder slettes fra alle synkroniserede enheder. Husk at sikre, at du stadig har adgang til dine konti.</string>
-
     <plurals name="credentialManagementDeleteAllPasswordsSnackbarConfirmation" instruction="Placeholder is a number representing how many passwords were deleted">
         <item quantity="one">%1$d adgangskode slettet</item>
         <item quantity="other">%1$d adgangskoder slettet</item>

autofill/autofill-impl/src/main/res/values-de/strings-autofill-impl.xml

@@ -120,7 +120,6 @@
     <string name="saveLoginDialogSubtitle">Passwörter werden sicher auf deinem Gerät gespeichert.</string>
     <string name="autofillManagementAddLogin">Passwort hinzufügen</string>
     <string name="credentialManagementEditLoginTitleHint">Titel</string>
-    <string name="autofillDeleteLoginDialogTitle">Möchtest du dieses Passwort wirklich löschen?</string>
     <string name="autofillManagementDeletedConfirmation">Passwort gelöscht</string>
     <string name="credentialManagementEditLastUpdated" instruction="Placeholder is a date">Zuletzt aktualisiert %1$s</string>
     <string name="autofillDisableAutofillPromptTitle">Möchtest du weiterhin Passwörter speichern?</string>
@@ -149,9 +148,6 @@
         <item quantity="other">Möchtest du diese %1$d Passwörter wirklich löschen?</item>
     </plurals>
 
-    <string name="credentialManagementDeletePasswordConfirmationMessage">Dein Passwort wird von allen synchronisierten Geräten gelöscht. Vergewissere dich, dass du weiterhin eine Möglichkeit hast, auf dein Konto zuzugreifen.</string>
-    <string name="credentialManagementDeleteAllPasswordsConfirmationMessage">Deine Passwörter werden von allen synchronisierten Geräten gelöscht. Vergewissere dich, dass du weiterhin eine Möglichkeit hast, auf deine Konten zuzugreifen.</string>
-
     <plurals name="credentialManagementDeleteAllPasswordsSnackbarConfirmation" instruction="Placeholder is a number representing how many passwords were deleted">
         <item quantity="one">%1$d Passwort gelöscht</item>
         <item quantity="other">%1$d Passwörter gelöscht</item>

autofill/autofill-impl/src/main/res/values-el/strings-autofill-impl.xml

@@ -120,7 +120,6 @@
     <string name="saveLoginDialogSubtitle">Οι κωδικοί πρόσβασης αποθηκεύονται με ασφάλεια στη συσκευή σας.</string>
     <string name="autofillManagementAddLogin">Προσθήκη κωδικού πρόσβασης</string>
     <string name="credentialManagementEditLoginTitleHint">Τίτλος</string>
-    <string name="autofillDeleteLoginDialogTitle">Θέλετε σίγουρα να διαγράψετε αυτόν τον κωδικό πρόσβασης;</string>
     <string name="autofillManagementDeletedConfirmation">Διαγραφή κωδικού πρόσβασης</string>
     <string name="credentialManagementEditLastUpdated" instruction="Placeholder is a date">Τελευταία ενημέρωση %1$s</string>
     <string name="autofillDisableAutofillPromptTitle">Θέλετε να συνεχίσετε να αποθηκεύετε κωδικούς πρόσβασης;</string>
@@ -149,9 +148,6 @@
         <item quantity="other">Θέλετε σίγουρα να διαγράψετε %1$d κωδικούς πρόσβασης;</item>
     </plurals>
 
-    <string name="credentialManagementDeletePasswordConfirmationMessage">Ο κωδικός πρόσβασής σας θα διαγραφεί από όλες τις συγχρονισμένες συσκευές. Βεβαιωθείτε ότι έχετε ακόμα τρόπο πρόσβασης στον λογαριασμό σας.</string>
-    <string name="credentialManagementDeleteAllPasswordsConfirmationMessage">Οι κωδικοί πρόσβασής σας θα διαγραφούν από όλες τις συγχρονισμένες συσκευές. Βεβαιωθείτε ότι έχετε ακόμα τρόπο πρόσβασης στους λογαριασμούς σας.</string>
-
     <plurals name="credentialManagementDeleteAllPasswordsSnackbarConfirmation" instruction="Placeholder is a number representing how many passwords were deleted">
         <item quantity="one">%1$d κωδικός πρόσβασης διαγράφηκε</item>
         <item quantity="other">%1$d κωδικοί πρόσβασης διαγράφηκαν</item>