Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mysql_scanner into main duckdb CI #11999

Merged
merged 2 commits into from May 13, 2024
Merged

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented May 10, 2024

DuckDB side of duckdb/duckdb_mysql#66, plus patches that are needed on top (to be absorbed before v0.10.3).

There is a single patch (since it was faster on my side), but logically it covers:

  • changes to make vcpkg aware of cross compilation
  • std::make_unique -> make_unique_ptr
  • BindUpdateConstraints API changes
  • MySQLScannerExtension -> MysqlScannerExtension due to limitations on generation script (to be solved script side OR duckdb_mysql side)

@Mytherin Mytherin merged commit 3cad172 into duckdb:main May 13, 2024
41 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request May 13, 2024
@carlopi carlopi deleted the mysql_main branch May 22, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants