Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extension load error message grammar #11994

Merged

Conversation

softprops
Copy link
Contributor

I experienced some unusual grammar when trying to load an extension that didn't line up with the running DuckDB. Below is the before and after of the messaging change

before

Invalid Input Error: Extension "zig-out/lib/quack.duckdb_extension" do not have metadata compatible with DuckDB loading it (version v0.10.2, platform osx_arm64)

after

Invalid Input Error: Extension "zig-out/lib/quack.duckdb_extension" does not have metadata compatible with the DuckDB loading it (version v0.10.2, platform osx_arm64)

Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing this. There is an incoming rework of those messages, but we can as well having this is already.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 10, 2024 13:46
@softprops softprops marked this pull request as ready for review May 10, 2024 14:27
@softprops
Copy link
Contributor Author

Let me know if I can help

@Mytherin Mytherin merged commit 87f33a9 into duckdb:main May 13, 2024
43 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request May 13, 2024
Merge pull request duckdb/duckdb#11994 from softprops/fix-extension-load-error-message-grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants