[Python] Make the NumPy module optional, not throwing if it's not installed #11981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
May 13, 2024
Merge pull request duckdb/duckdb#11831 from samansmink/hugging-face-fs Merge pull request duckdb/duckdb#11981 from Tishj/python_optional_numpy Merge pull request duckdb/duckdb#11980 from Tishj/pyfs_needs_gil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11871
We don't have an explicit dependency on NumPy.
Without this change, when attempting to check the type of a python object, we attempt to import this module.
If it's not available we throw, even when we are just trying to do an
isinstancecheck.This might require a better fix at some point, for now this makes sure the error isn't thrown if NumPy is missing.