Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Grab the GIL in the destructor of PyFilesystem #11980

Merged
merged 1 commit into from May 13, 2024
Merged

[Python] Grab the GIL in the destructor of PyFilesystem #11980

merged 1 commit into from May 13, 2024

Conversation

Tishj
Copy link
Contributor

@Tishj Tishj commented May 8, 2024

This needs to hold the GIL when its being destroyed, as it contains a python object.

@Tishj
the pyfile system is holding a py::object, we need to make sure it ho…
1c17c6d 
…lds the GIL when that object is being destructed
@Mytherin Mytherin merged commit e9e1992 into duckdb:main May 13, 2024
16 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request May 13, 2024
@krlmlr
chore: Update vendored sources to duckdb/duckdb@b9ecd8d
03f1ffd 
Merge pull request duckdb/duckdb#11831 from samansmink/hugging-face-fs
Merge pull request duckdb/duckdb#11981 from Tishj/python_optional_numpy
Merge pull request duckdb/duckdb#11980 from Tishj/pyfs_needs_gil
@Mytherin Mytherin mentioned this pull request May 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tishj @Mytherin