Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update exception message #11965

Merged
merged 2 commits into from May 13, 2024
Merged

chore: update exception message #11965

merged 2 commits into from May 13, 2024

Conversation

stephaniewang526
Copy link
Contributor

@stephaniewang526 stephaniewang526 commented May 7, 2024

Update to throw IOException since the error message exposes a db file path.

@hannes
Copy link
Member

hannes commented May 8, 2024

Right but normal CLI users would find the path more useful or am I missing something?

@stephaniewang526
Copy link
Contributor Author

Right but normal CLI users would find the path more useful or am I missing something?

In that case, could we throw IOException (instead of CaralogException) here?

@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 8, 2024 11:15
@stephaniewang526 stephaniewang526 marked this pull request as ready for review May 8, 2024 11:15
@Mytherin Mytherin merged commit 9e44e7a into duckdb:main May 13, 2024
40 of 41 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request May 13, 2024
Merge pull request duckdb/duckdb#11965 from stephaniewang526/fix-ex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants