Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between exact and case insensitive matching JSON keys in json_structure #11948

Merged
merged 4 commits into from May 13, 2024

Conversation

lnkuiper
Copy link
Contributor

@lnkuiper lnkuiper commented May 6, 2024

The json_structure function now ignores errors again (like it used to), so these are allowed:

select json_structure('{"a": 1, "a": 1}');
-- {"a":"UBIGINT"}
select json_structure('{"a": 1, "A": 1}');
-- {"a":"UBIGINT","A":"UBIGINT"}

Fixes #11886

@hannes
Copy link
Member

hannes commented May 8, 2024

Can you check the failing tests please?

@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 8, 2024 08:37
@lnkuiper lnkuiper marked this pull request as ready for review May 8, 2024 08:39
@duckdb-draftbot duckdb-draftbot marked this pull request as draft May 8, 2024 13:21
@lnkuiper lnkuiper marked this pull request as ready for review May 8, 2024 13:45
@Mytherin Mytherin merged commit d27f06c into duckdb:main May 13, 2024
41 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request May 13, 2024
Merge pull request duckdb/duckdb#11867 from Maxxen/index-binding
Merge pull request duckdb/duckdb#11948 from lnkuiper/json_structure_fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON_GROUP_STRUCTURE is now (incorrectly?) case sensitive
3 participants