Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Age based eviction steady #11904

Closed
wants to merge 6 commits into from
Closed

Conversation

jkub
Copy link
Contributor

@jkub jkub commented May 2, 2024

This PR exists only to a/b test the performance of std::steady_clock vs. custom implementation.

This is the same as this pr #11441
except it uses steady_clock instead of the custom implementation.

@jkub
Copy link
Contributor Author

jkub commented May 2, 2024

CI always fails on draft PRs. I don't know why.

@Mytherin Mytherin marked this pull request as ready for review May 2, 2024 20:46
@Mytherin
Copy link
Collaborator

Mytherin commented May 2, 2024

There are no different CI rules for draft PRs - I think the CI was failing because the PR used std::shared_ptr explicitly and we recently introduced duckdb::shared_ptr (see #11696).

@Mytherin
Copy link
Collaborator

Superseded by #11441

@Mytherin Mytherin closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants