Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing fail_ci_if_error option #331

Merged
merged 1 commit into from
May 13, 2024
Merged

Removing fail_ci_if_error option #331

merged 1 commit into from
May 13, 2024

Conversation

rhui-dbx
Copy link
Contributor

Disabling the fail_ci_if_error option for CodeCov since it's not working.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.93%. Comparing base (16c60f2) to head (1d7d470).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   51.93%   51.93%           
=======================================
  Files          37       37           
  Lines        8419     8419           
  Branches     1809     1809           
=======================================
  Hits         4372     4372           
  Misses       3731     3731           
  Partials      316      316           
Flag Coverage Δ
unit 51.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhui-dbx rhui-dbx merged commit cbe085a into main May 13, 2024
10 of 12 checks passed
@rhui-dbx rhui-dbx deleted the disable_code_cov branch May 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants