Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for google app engine #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sserrano44
Copy link

pkg_resources is not available

@@ -1,5 +1,5 @@
from itertools import groupby
import pkg_resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, pkg_resources is better for this purpose because provides support for accessing data files residing in the module even when the module is actually loaded from a zipfile. This request drops that ability.

I imagine that pkg_resources is not available on Google App Engine since it's not standard? But in order to not regress the behavior, could you please modify this pull request to try to import and use the pkg_resources method, and if it fails, fall back to using the filesystem?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants