Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.2-3.4 compatibility and enable distribution as a wheel #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

moreati
Copy link

@moreati moreati commented Jun 23, 2015

No description provided.

gwachob and others added 4 commits December 5, 2014 17:16
Iteration over a dictionary does not have a defined order. Iterate over
a specified list of keys so the output is more predicatable.
This commit
- Makes python-zxcvbn compatible with Python 2.6, 2.7, 3.2, 3.3 and 3.4
- Removes dependance on the third-party package Future
- Switches from distutils -> setuptools; to allow installation as e.g.
   an egg, a wheel or installing in development mode
@msom
Copy link

msom commented Jul 28, 2015

+1

@jonafato
Copy link

jonafato commented Nov 6, 2015

Would love to see this merged. I'd like to start incorporating this into a couple of projects, but Python 3 is a hard requirement for me.

@msegado
Copy link

msegado commented Dec 7, 2015

+1

@gibsjose
Copy link

+1, although I'm still weary to use after issue #14. Also, the documentation for the dictionary keys is incorrect for calculation_time. It should be calc_time.

@shacker
Copy link

shacker commented Jun 13, 2016

Very unfortunate not to see this PR for Python3 support merged six months later. Is this now considered a dead project? This just became a roadblock for my org.

@dwolfhub
Copy link

consider using this version, which supports python3 and is up to date with the current version of the javascript library, so results will match.

https://github.com/dwolfhub/zxcvbn-python

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ gwachob
❌ moreati
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants