Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a fixer to get signature data from a command #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chadrik
Copy link
Contributor

@chadrik chadrik commented Apr 18, 2020

Throwing this up here to see if it sticks. I still have more testing to do, but I'd like to find out if I'm headed in the right direction or not.

It can be used like this:

dmypy run -- --follow-imports=error pyannotate_tools
pyannotate pyannotate_tools -c "dmypy suggest --json {filename}:{lineno}" --type-info=""

The idea is that you can enable both fixers -- json and command -- and if the json fixer doesn't provide a type annotation, then the command fixer will run and take a shot at it. Both fixers will bail if there is already an annotation. The order is determined by the run_order class variable.

@chadrik chadrik changed the title [WIP] Add an option to specify a command to get signature data [WIP] Add an option for a command to get signature data Apr 18, 2020
@chadrik chadrik changed the title [WIP] Add an option for a command to get signature data [WIP] Add a fixer to get signature data from a command Apr 18, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants