Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to fix CI for ARM Mac and older dotnet format tool compatbility #360

Merged
merged 26 commits into from
May 15, 2024

Conversation

eli-iser
Copy link
Contributor

@eli-iser eli-iser commented May 10, 2024

Current CI builds fail. There are a few issues that this PR attempts to resolve:

  • Tests on macos-latest fail with You can resolve the problem by installing the 'X64' .NET.. This is due to macos-latest being an ARM based runner, and .NET Standard 2.0/.NET 5 only supports x64. I moved to macos-13 which appears to be the latest version still using Intel CPUs. Note that macos-11 is being deprecated on 6/28/2024 so we should have some time yet with macos-13 to upgrade the SDK to support ARM build.
  • Linter fails because the --fix- commands are not supported in dotnet format 6 and above. I pinned the version to 5 that still supports them. Ideally we'd want to see how to configure the latest format tool to do what we want, but for a quick fix/test I'm trying the "original" version. This also required moving from dotnet format (which always ran the latest version) to dotnet-format (which did run the correct version that was installed).
  • Code coverage report uploading were missing the Codecov token to allow them to be uploaded. I've added the token to the GitHub secrets and reference it here.

Also updated the contribution doc with the above dotnet format version and removed the Stone generation section as it is no longer supported (instead being handled by the Spec Update action).

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does this code build successfully?
  • Do all tests pass?
  • Does Stylecop pass?

@eli-iser eli-iser requested review from greg-db and removed request for greg-db May 10, 2024 18:45
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.89%. Comparing base (c6415d8) to head (cfbe93c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   51.33%   47.89%   -3.44%     
==========================================
  Files          14       17       +3     
  Lines        1422     1570     +148     
  Branches        0      137     +137     
==========================================
+ Hits          730      752      +22     
- Misses        692      776      +84     
- Partials        0       42      +42     
Flag Coverage Δ
integration 44.77% <ø> (-2.84%) ⬇️
unit 9.42% <ø> (-1.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eli-iser eli-iser self-assigned this May 15, 2024
@sahujapersonal sahujapersonal self-requested a review May 15, 2024 18:21
@eli-iser eli-iser merged commit 0ff5668 into main May 15, 2024
11 of 12 checks passed
@eli-iser eli-iser deleted the ci-fixes branch May 15, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants