Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change URI process start. #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

babichhunter
Copy link

@babichhunter babichhunter commented May 8, 2022

When attempting to run a windows service, "File not found error" was raised. Proposed change fixes this issue.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does this code build successfully?
  • Do all tests pass?
  • Does Stylecop pass?

When attempting to run a windows service, "File not found error" was raised. Proposed change fixes this issue.
@CLAassistant
Copy link

CLAassistant commented May 8, 2022

CLA assistant check
All committers have signed the CLA.

@greg-db
Copy link
Contributor

greg-db commented May 9, 2022

Can you share some more information about the error you're referring to? For instance, the specific steps to reproduce the error, as well as the full error output you're getting would be helpful reference for this. Thanks in advance!

@babichhunter
Copy link
Author

Running windows service using .Net 6.0 in Visual Studio.
Output Type: Console Application (debug)
Log file from the service attached with the Win32Exception. (client ID is masked)
Looks like it tries to open the authentication URL as a file and not as a webpage.

HDBS_LogFile.txt

@greg-db
Copy link
Contributor

greg-db commented May 11, 2022

Thanks! I'll ask the team to review this.

@@ -240,7 +240,8 @@ private async Task<string> GetAccessToken()

http.Start();

System.Diagnostics.Process.Start(authorizeUri.ToString());
System.Diagnostics.Process.Start(new ProcessStartInfo(authorizeUri.ToString()) { UseShellExecute = true });
//System.Diagnostics.Process.Start(authorizeUri.ToString());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this will work for all use cases. Please instead leave the original code, and add a comment explaining this alternative method and when you'd need to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants