Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create _TZE204_bkkmqmyo_energy_meter.json #7692

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maltekluever
Copy link

Added DDF for Hiking Single Phase 65A DIN Rail Energy Meter (modelid: TS0601, manufacturer: _TZE204_bkkmqmyo)

see:
#7564

Added DDF for Hiking Single Phase 65A DIN Rail Energy Meter (modelid: TS0601, manufacturer: _TZE204_bkkmqmyo)

see: 
dresden-elektronik#7564
@Smanar
Copy link
Collaborator

Smanar commented Apr 4, 2024

Hello, there is some changes needed.

  • Replace all "fn": "zcl" by "fn": "zcl:attr"

Replaced:
"fn": "zcl"

with:
"fn": "zcl:attr"
@manup
Copy link
Member

manup commented Apr 20, 2024

@Smanar should we go with a more generic name for the file?

tS0601_energy_meter.json

@Smanar
Copy link
Collaborator

Smanar commented Apr 20, 2024

I have just take a look on tuya folder https://github.com/dresden-elektronik/deconz-rest-plugin/tree/master/devices/tuya
And all DDF are on form ModelID_DeviceTypejson or ManufactureName_DeviceType.json
The problem is even ModelID are not constant, so you want to use only the Device Type ?

If you want you can validate this PR, and I will make a new one to rename all Tuya DDF, but what you prefer as Model Name for them ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants