Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error messages to be more precise #7286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bluemoehre
Copy link
Contributor

Hue has added more effects than Colorloop. Now we also have Candle & Fireplace. So we have to be more generic with this message.

Hue has added more effects than Colorloop. Now we also have Candle & Fireplace. So we have to be more generic with this message.
@bluemoehre
Copy link
Contributor Author

Also we need to adapt the corresponding variable & function names.

@ebaauw
Copy link
Collaborator

ebaauw commented Oct 8, 2023

This is not going to work. The isColorLoopActive() checks only for colorloop. The special effects work very differently on Zigbee level, and are manufacturer-specific (Hue implements them differently from Mueller and from the LIDL Xmas light strip). In hindsight, I half regret exposing both using state.effect. Also note that colormode is hs for colorloop, but effect for the special effects.

I think setting the color(temperature) while a special effect is active actually terminates the effect, where this is simply ignored while colorloop is active (hence the check).

@bluemoehre
Copy link
Contributor Author

bluemoehre commented Oct 9, 2023

If I activate the Candle or Fireplace effect and after PUT something with sat or bri I get the response error "colorloop is active".
The effect is not terminated.
To terminate the effect I need to add effect: 'none'.

Also note that colormode is hs for colorloop, but effect for the special effects.

Wow, you are right - this will add even more irritation.

In my opinion the whole effect thing is kinda bad made (by Philips). Why not having an effect which starts with "defaults" but allow to overwrite things like color of candle. Well, that's another story ;)

EDIT: okay, actually candle allows to overwrite bri but not in the same request which enables the effect. =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants