Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filterRenderController works after selectionRenderService is usable #2236

Merged
merged 3 commits into from
May 14, 2024

Conversation

siam-ese
Copy link
Contributor

close 2108

The code needs to run online, Just got env ready for QA verification. cc @oumomomo

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 30.78%. Comparing base (84620d4) to head (b0f7faa).
Report is 1 commits behind head on dev.

Files Patch % Lines
...src/controllers/sheets-filter-render.controller.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2236   +/-   ##
=======================================
  Coverage   30.78%   30.78%           
=======================================
  Files        1275     1275           
  Lines       70194    70194           
  Branches    14788    14787    -1     
=======================================
  Hits        21608    21608           
  Misses      48586    48586           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@siam-ese siam-ese changed the title To close #2108 fix:to close #2108 May 14, 2024
@siam-ese siam-ese changed the title fix:to close #2108 fix: to close #2108 May 14, 2024
@oumomomo
Copy link

@wzhudev 这个验收完了

@univer-bot
Copy link

univer-bot bot commented May 14, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@wzhudev This acceptance is complete

@wzhudev
Copy link
Member

wzhudev commented May 14, 2024

@wzhudev 这个验收完了

来个 QA:verified tag

@univer-bot
Copy link

univer-bot bot commented May 14, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@wzhudev This acceptance is complete

Come up with a QA: verified tag

@wzhudev
Copy link
Member

wzhudev commented May 14, 2024

@siam-ese Please change the title of the PR to make it more descriptive.

@siam-ese siam-ese changed the title fix: to close #2108 fix: filterRenderController works after selectionRenderService is usable May 14, 2024
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 14, 2024
@siam-ese siam-ese added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels May 14, 2024
@wzhudev wzhudev merged commit 3693e7a into dev May 14, 2024
10 checks passed
@wzhudev wzhudev deleted the lzp/fix-filter-border branch May 14, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] There is a filter in the table, and the filter border position is abnormal when switching sub-tables.
3 participants