Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sheet): add tooltip to FilterPanel #2234

Merged
merged 8 commits into from
May 16, 2024
Merged

feat(sheet): add tooltip to FilterPanel #2234

merged 8 commits into from
May 16, 2024

Conversation

siam-ese
Copy link
Contributor

close #2111

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@siam-ese siam-ese added the qa:untested This PR is ready to be tested label May 14, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 16, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label May 16, 2024
jikkai
jikkai approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siam-ese siam-ese merged commit 12d4aef into dream-num:dev May 16, 2024
9 checks passed
@siam-ese siam-ese deleted the lzp/feat-filter-panel-tooltip branch May 16, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikkai jikkai jikkai approved these changes

@ybzky ybzky Awaiting requested review from ybzky ybzky is a code owner

@yuhongz yuhongz Awaiting requested review from yuhongz yuhongz is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] add tipinfo in view of sheets-filter-ui
3 participants
@siam-ese @jikkai @oumomomo