Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render-engine): optimize underline postion #2164

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 6, 2024

close #1860

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 31.08%. Comparing base (9edf924) to head (d020e40).

Files Patch % Lines
.../engine-render/src/components/docs/layout/tools.ts 0.00% 4 Missing ⚠️
...gine-render/src/components/docs/extensions/line.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2164      +/-   ##
==========================================
- Coverage   31.08%   31.08%   -0.01%     
==========================================
  Files        1209     1209              
  Lines       66296    66299       +3     
  Branches    14026    14025       -1     
==========================================
  Hits        20607    20607              
- Misses      45689    45692       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review May 6, 2024 09:19
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 6, 2024
Copy link

github-actions bot commented May 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo
Copy link

oumomomo commented May 6, 2024

上标的下划线位置太下
image

@univer-bot
Copy link

univer-bot bot commented May 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

The superscript and underline are too far down
image

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The position of the subscript and underline in the document is inconsistent
2 participants