Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(permission): support permission #1931

Merged
merged 10 commits into from
May 28, 2024
Merged

feat(permission): support permission #1931

merged 10 commits into from
May 28, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Apr 16, 2024 •
edited

close #540

@Gggpound Gggpound marked this pull request as draft April 16, 2024 13:23
@Gggpound Gggpound changed the title Feat/permission 0415 feat(permission): support permission Apr 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited

Codecov Report

Attention: Patch coverage is 8.70910% with 3543 lines in your changes are missing coverage. Please review.

Project coverage is 29.15%. Comparing base (8cd421b) to head (88a1d9e).
Report is 1 commits behind head on dev.

Files Patch % Lines
.../sheet-permission-interceptor-render.controller.ts 0.00% 591 Missing ⚠️
...ion/range-permission/range-protection.ref-range.ts 0.00% 324 Missing ⚠️
...ackages/sheet-permission-ui/src/controller/util.ts 0.00% 218 Missing ⚠️
...ckages/sheets-ui/src/controllers/menu/menu-util.ts 12.28% 200 Missing ⚠️
...mission-ui/src/command/range-protection.command.ts 0.00% 180 Missing ⚠️
...eet-permission-ui/src/views/panel-detail/index.tsx 0.00% 169 Missing ⚠️
...src/controller/sheet-permission-init.controller.ts 0.00% 156 Missing ⚠️
...sheet-permission-ui/src/views/panel-list/index.tsx 0.00% 139 Missing ⚠️
...ssion/range-permission/range-protection.service.ts 0.00% 80 Missing ⚠️
...re/src/services/authz-io/authz-io-local.service.ts 1.26% 78 Missing ⚠️
... and 97 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1931      +/-   ##
==========================================
- Coverage   30.05%   29.15%   -0.91%     
==========================================
  Files        1421     1515      +94     
  Lines       73107    76704    +3597     
  Branches    15317    15925     +608     
==========================================
+ Hits        21975    22360     +385     
- Misses      51132    54344    +3212

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound force-pushed the feat/permission-0415 branch 5 times, most recently from 725ee2e to fccaed3 Compare April 26, 2024 03:10
@Gggpound Gggpound force-pushed the feat/permission-0415 branch 6 times, most recently from 7d2f8eb to babc5c2 Compare May 6, 2024 13:44
@Gggpound Gggpound force-pushed the feat/permission-0415 branch 4 times, most recently from 8f6df5c to 24fa756 Compare May 13, 2024 11:51
@ybzky ybzky force-pushed the feat/permission-0415 branch 2 times, most recently from 1afae29 to 18c668c Compare May 17, 2024 11:59
@Gggpound Gggpound marked this pull request as ready for review May 18, 2024 02:27
wzhudev
wzhudev requested changes May 25, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few headsup:

  1. Please follow our naming convention.
  2. Please avoid exposing methods or properties that are not called by outside code

@Gggpound Gggpound force-pushed the feat/permission-0415 branch 2 times, most recently from 825c215 to 3551c38 Compare May 27, 2024 02:54
@Gggpound Gggpound added the qa:untested This PR is ready to be tested label May 28, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 28, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label May 28, 2024
wzhudev
wzhudev requested changes May 28, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code readability issue need to be addressed.

packages/core/src/services/authz-io/authz-io.ts Outdated Show resolved Hide resolved
packages/debugger/src/commands/operations/set.editable.operation.ts Outdated Show resolved Hide resolved
packages/design/src/components/switch/Switch.tsx Show resolved Hide resolved
packages/sheet-permission-ui/src/command/range-protection.command.ts Outdated Show resolved Hide resolved
packages/sheet-permission-ui/src/controller/sheet-permission.interceptor.controller.ts Outdated Show resolved Hide resolved
wzhudev
wzhudev approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gggpound Gggpound merged commit 09fd989 into dev May 28, 2024
9 checks passed
@Gggpound Gggpound deleted the feat/permission-0415 branch May 28, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

@ybzky ybzky Awaiting requested review from ybzky ybzky is a code owner

@yuhongz yuhongz Awaiting requested review from yuhongz yuhongz is a code owner

@weird94 weird94 Awaiting requested review from weird94 weird94 is a code owner

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir is a code owner

@hexf00 hexf00 Awaiting requested review from hexf00 hexf00 is a code owner

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku is a code owner

@siam-ese siam-ese Awaiting requested review from siam-ese siam-ese is a code owner

Assignees

@ybzky ybzky

Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gggpound @wzhudev @ybzky @zhaolixin7