Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheet): render viewport wrong size #1727

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from
Draft

fix(sheet): render viewport wrong size #1727

wants to merge 13 commits into from

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 28, 2024 •
edited by jikkai

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 695 lines in your changes are missing coverage. Please review.

Project coverage is 30.02%. Comparing base (7ea04cf) to head (0b81b50).
Report is 1 commits behind head on dev.

Files Patch % Lines
packages/engine-render/src/viewport.ts 0.00% 261 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 160 Missing ⚠️
...eets-ui/src/controllers/sheet-render.controller.ts 0.00% 54 Missing ⚠️
packages/engine-render/src/basics/tools.ts 0.00% 29 Missing ⚠️
packages/engine-render/src/layer.ts 0.00% 28 Missing ⚠️
packages/sheets-ui/src/views/sheet-canvas-view.ts 0.00% 20 Missing ⚠️
...ne-render/src/components/sheets/extensions/font.ts 0.00% 18 Missing ⚠️
...der/src/components/sheets/extensions/background.ts 0.00% 17 Missing ⚠️
...rc/components/sheets/extensions/sheet-extension.ts 0.00% 15 Missing ⚠️
.../engine-render/src/components/sheets/interfaces.ts 0.00% 10 Missing ⚠️
... and 30 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1727      +/-   ##
==========================================
- Coverage   30.16%   30.02%   -0.15%     
==========================================
  Files        1418     1418              
  Lines       72561    72921     +360     
  Branches    15201    15280      +79     
==========================================
+ Hits        21891    21892       +1     
- Misses      50670    51029     +359

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix-render-viewport-error branch 8 times, most recently from 1b22409 to 5cd7a36 Compare April 23, 2024 12:54
DR-Univer and others added 13 commits May 24, 2024 17:03
@DR-Univer @lumixraku
fix(sheet): render viewport wrong size
b5287a8
@lumixraku
fix: new viewport need more param
0027171
@lumixraku
feat: cache by viewport
ffe97fd 
chore: merge fix1

fix: fix viewport start pos

feat: add vp dirty when moving range

fix: shrink font extension merge range

fix: zoom out cause blank area!!

chore: fix viewport mainCtx scaling

chore: better code 2

chore: better code2

chore: update with dev

chore: turn off test canvas
@lumixraku
fix: markdirty & scrolling was conflict before, so scrolling & dirty …
5b16202 
…did not refresh whole viewport
@lumixraku
fix: 0510-1725
1ec8a2d 
fix: #676 #677

fix: browser native zoom
@lumixraku
fix: blurry when applyCache especially in windows 175%
a3111e4
@lumixraku
fix: merge cells background
b700bbb 
fix: #676

test: #677

fix: #700

fix: aux line background

fix: spreadsheet

fix: precise rect for background
@weird94 @lumixraku
feat: fix cf render error on printing mode
43bfb91 
fix: #700
@lumixraku
fix: viewport make dirty false
5f5a6fc 
chore: eslint fix
@jikkai @lumixraku
test(facade): fix canvas mock
4c2d87e 
fix: new viewport need more param222

test: mock canvas

fix: rm useless
@lumixraku
fix: should beginPath before clip()
f97db72
@lumixraku
chore: comments to english
cfae458 
fix: expand shouldupdatecache

chore: better code
@lumixraku
fix: change viewport update timing
0b81b50 
fix: update visible cache viewport area
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikkai jikkai Awaiting requested review from jikkai jikkai will be requested when the pull request is marked ready for review jikkai is a code owner

@Gggpound Gggpound Awaiting requested review from Gggpound Gggpound will be requested when the pull request is marked ready for review Gggpound is a code owner

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev will be requested when the pull request is marked ready for review wzhudev is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs will be requested when the pull request is marked ready for review Jocs is a code owner

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir will be requested when the pull request is marked ready for review Dushusir is a code owner

@hexf00 hexf00 Awaiting requested review from hexf00 hexf00 will be requested when the pull request is marked ready for review hexf00 is a code owner

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku will be requested when the pull request is marked ready for review lumixraku is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DR-Univer @lumixraku @weird94 @jikkai