Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): create univer sheet by snapshot #1570

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Mar 13, 2024

⚠️[Do not merge] To be discussed

  • I am sure that the code is update-to-date with the dev branch.
  • createUniverSheet 支持 ISnapshotSheetBlockObject
  • createUniverSheetByConfig 支持 IWorkbookData
  • 接口转换内置到 core: packages/core/src/services/snapshot/snapshot-transform.ts
    更多注意事项 https://github.com/dream-num/univer-pro/issues/406

Copy link

github-actions bot commented Mar 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 89.13043% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 32.97%. Comparing base (54da0dc) to head (07a05a6).
Report is 7 commits behind head on dev.

Files Patch % Lines
packages/core/src/basics/univer.ts 14.28% 6 Missing ⚠️
...kages/core/src/services/snapshot/snapshot-utils.ts 84.61% 2 Missing ⚠️
...ges/core/src/services/instance/instance.service.ts 0.00% 1 Missing ⚠️
packages/facade/src/apis/facade.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1570      +/-   ##
==========================================
+ Coverage   32.90%   32.97%   +0.07%     
==========================================
  Files         919      920       +1     
  Lines       51149    51307     +158     
  Branches    10645    10700      +55     
==========================================
+ Hits        16829    16917      +88     
- Misses      34320    34390      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Codecov Report

Attention: Patch coverage is 89.13043% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 32.97%. Comparing base (54da0dc) to head (07a05a6).
Report is 7 commits behind head on dev.

Files Patch % Lines
packages/core/src/basics/univer.ts 14.28% 6 Missing ⚠️
...kages/core/src/services/snapshot/snapshot-utils.ts 84.61% 2 Missing ⚠️
...ges/core/src/services/instance/instance.service.ts 0.00% 1 Missing ⚠️
packages/facade/src/apis/facade.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1570      +/-   ##
==========================================
+ Coverage   32.90%   32.97%   +0.07%     
==========================================
  Files         919      920       +1     
  Lines       51149    51307     +158     
  Branches    10645    10700      +55     
==========================================
+ Hits        16829    16917      +88     
- Misses      34320    34390      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as ready for review March 14, 2024 03:28
@Dushusir Dushusir marked this pull request as draft March 16, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants