refactor: move module query-methods into collection-decorator #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebycliff
reviewed
Feb 26, 2020
|
|
||
| # Configures the strategy used to proxy the query methods, which defaults to `:active_record`. | ||
| def strategy | ||
| @strategy ||= LoadStrategy.new(Draper.default_query_methods_strategy) |
There was a problem hiding this comment.
Does the name LoadStrategy still make sense in this new context? Should it be something like QueryMethodStrategy or something more specific to query methods? I don't have a big opinion here, but it does seem odd.
|
@brunohkbx can you please rebase your branch on master ? Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we discussed on #868, it makes sense to move this module into CollectionDecorator since it depends upon
decorator_classandcontext.