fix: pass through the headers specified by user to preheat job #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlins
force-pushed
the
fix/preheat-headers
branch
2 times, most recently
from
1955730
to
eb2fff0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3257 +/- ##
==========================================
- Coverage 52.84% 52.74% -0.10%
==========================================
Files 192 192
Lines 20355 20372 +17
==========================================
- Hits 10756 10746 -10
- Misses 8798 8819 +21
- Partials 801 807 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@chlins Please fix CI. |
Background: Harbor utilizes the V1 preheat job, which includes the auth token issued by Harbor in the request body. However, Dragonfly 2.x's auth logic relies on the username and password to exchange tokens, following the v2 auth flow. As a result, when Harbor attempts to preheat to Dragonfly 2.x, it encounters a 401 unauthorized error as Dragonfly tries to pull the manifest from the private project. To maintain backward compatibility, the auth logic should be aligned to be compatible with 1.x. Signed-off-by: chlins <chenyuzh@vmware.com>
chlins
force-pushed
the
fix/preheat-headers
branch
from
eb2fff0
to
d91b310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Background:
Harbor utilizes the V1 preheat job, which includes the auth token issued by Harbor in the request body. However, Dragonfly 2.x's auth logic relies on the username and password to exchange tokens, following the v2 auth flow. As a result, when Harbor attempts to preheat to Dragonfly 2.x, it encounters a 401 unauthorized error as Dragonfly tries to pull the manifest from the private project. To maintain backward compatibility, the auth logic should be aligned to be compatible with 1.x.
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist