Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix traffic swap #3188

Merged
merged 1 commit into from May 16, 2024
Merged

fix traffic swap #3188

merged 1 commit into from May 16, 2024

Conversation

aobt
Copy link
Contributor

@aobt aobt commented Apr 10, 2024

Using Swap to keep the usingBandWidth swap into lastSecondBandwidth atomically;

otherwise, between Load() and Store(0), usingBandWidth may be added, that will be dropped unexpectedly;

@aobt aobt requested a review from a team as a code owner April 10, 2024 14:50
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.97%. Comparing base (5cee901) to head (15a6fab).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3188      +/-   ##
==========================================
- Coverage   52.00%   51.97%   -0.04%     
==========================================
  Files         173      173              
  Lines       19354    19352       -2     
==========================================
- Hits        10065    10058       -7     
- Misses       8582     8587       +5     
  Partials      707      707              
Flag Coverage Δ
unittests 51.97% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/daemon/peer/traffic_shaper.go 83.87% <100.00%> (-0.26%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 756b6b4 into dragonflyoss:main May 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants