Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eternal report #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Eternal report #28

wants to merge 1 commit into from

Conversation

wolfpack94
Copy link
Contributor

@wolfpack94 wolfpack94 commented Jul 13, 2020

Description

Implements new request: getEternalReport which generates an eternal-type report given a transaction ID

Checklist
  • yarn test:ci passes
  • tests are included
  • documentation is changed or added

@codeclimate
Copy link

codeclimate bot commented Jul 13, 2020

Code Climate has analyzed commit 5752a65 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 10.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.6%.

View more on Code Climate.

@emtesenair
Copy link

Should the request name be more generic: getReport vs getEternalReport?

I'm assuming another request would be required to obtain subsequent first public blocks, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants