Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Droplet no quant #261

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Droplet no quant #261

wants to merge 48 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 5, 2020

Fixes performance issues with the droplet_swirl example by replacing containers with built-in types and implementing one Vortex per Droplet.

@azzaouit
Use full path for README image
1bac116
@azzaouit
Merge branch 'master' into taha
6b281b1
@azzaouit
Update README.md
bce58aa 
codecov
@azzaouit
Vortex Droplet 1-to-1
fda72ef
@azzaouit
Update documentation
b748b49
@azzaouit
Module type error
c90baa6
@azzaouit
Don't generate plots
a96a611
@azzaouit
Add mass balancing
bd9d4f7
@azzaouit
Adaptive time stepping
aa6eb62
@azzaouit
Fixed trajectory calculations
a96dd65
@azzaouit
Flatten trajectory and add delta t
d96612c
@azzaouit
mods
372b797
@azzaouit
Parse trajectories on the fly
9dd3bee
@azzaouit
Trajectory plotting
b3feda4
@azzaouit
Checkpointing
dd27b1b
@azzaouit
Bug fix
ff4e2a3
@azzaouit
component-wise calculation
19ab3b6
@azzaouit
Remove get time
f0870d9
@azzaouit
Send constant value
1ae1ef8
@azzaouit
Merge branch 'taha' into droplet-no-quant
4a9d520
@azzaouit
Removed unused imports
d526425
@azzaouit
Test without quantity and species
8b20d47
@azzaouit
Force mpi
3ebe02e
@azzaouit
Move params to main
dd601ee
@azzaouit
Pass num drops via command line
e7232b4
@azzaouit
Added script to run droplet in batches
ac7e287
@azzaouit
Time droplet runs and output elapsed time
b279d14
@azzaouit
Record output runs
2e82772
@azzaouit
plot num droplets vs running time
4062892
@azzaouit
Save droplet runs to csv
9753967
@ghost ghost requested a review from dealmeidavf January 5, 2020 15:43
dealmeidavf
dealmeidavf reviewed Feb 6, 2020
View reviewed changes
Copy link
Member

@dealmeidavf dealmeidavf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this. This certainly uncovers the issue with Pandas dataframes but a better fix is inside the Phase interface and not removing its usage. Changing Phase internally will preserve the interface and usage for all other modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dealmeidavf @azzaouit