v.0.3.0 Features and fixes

dpcat237 · May 16, 2020 · 41b89d5 · 41b89d5
1 parent e0a124f
commit 41b89d5
Show file tree

Hide file tree

Showing 6 changed files with 9,002 additions and 18 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,15 @@
+# 0.3.0 (2020.05.17)
+
+#### Features
+- Lowercase and replace spaces with _ in new tag
+- Improve regex for title extraction
+- Update dependencies
+
+#### Fixes
+- Prevent saving tag without URL and title
+- Prevent selecting multiple times same tag
+- Clean filtered tags after reopening without link
+
 # 0.2.0 (2020.05.10)
 
 #### Features

diff --git a/app/components/App.vue b/app/components/App.vue
@@ -127,12 +127,15 @@
         methods: {
             addNewTag() {
                 const tag = {
-                    name: this.tagField,
+                    name: this.cleanNewTag(this.tagField),
                 }
                 this.tagsAdded.push(tag)
                 this.tagField = ""
             },
             addSelectedTag(tag) {
+                if (this.isTagExists(tag)) {
+                    return
+                }
                 this.tagsAdded.push(tag)
                 this.tagField = ""
             },
@@ -145,12 +148,23 @@
                 this.tagsAdded = []
                 this.$store.dispatch('cleanTags')
             },
+            cleanNewTag(tag) {
+                return tag.toLowerCase().trim().replace(" ","_")
+            },
             getLinkDetails() {
                 if (this.urlField === "") {
                     return
                 }
                 this.$store.dispatch('getLink', this.urlField)
             },
+            isTagExists(tag) {
+                for (let i = 0; i < this.tagsAdded.length; i++) {
+                    if (this.tagsAdded[i].name === tag.name) {
+                        return true
+                    }
+                }
+                return false
+            },
             listenForShared() {
                 if (!application.android) {
                     return
@@ -187,6 +201,15 @@
                 }
             },
             saveLnk() {
+                if (this.urlField === '' || this.titleField === '') {
+                    alert({
+                        title: "Alert",
+                        message: "URL and title fields are required",
+                        okButtonText: "OK"
+                    })
+                    return;
+                }
+
                 const data = {
                     description: this.description,
                     isPrivate: false,
@@ -215,6 +238,11 @@
                 this.$store.dispatch('filterTags', this.tagField)
             },
         },
+        beforeUpdate() {
+            if (this.urlField === '') {
+                this.tagsAdded = []
+            }
+        },
         created() {
             this.listenForShared()
         },

diff --git a/app/store/modules/link.js b/app/store/modules/link.js
@@ -50,7 +50,11 @@ export default {
           .get(url)
           .then(function(response) {
             if (response.data.length > 0) {
-              let matches = response.data.match("<title>(.*?)</title>")
+              let matches = response.data.match("<title[^>]*>(.*?)</title>")
+              if (matches === null) {
+                console.log('Error looking for title in body')
+                return
+              }
               if (matches.length > 0) {
                 let link = {
                   id: "",
@@ -86,6 +90,7 @@ export default {
             }
           },
           error => {
+            console.log('Error saving link ' + error)
             commit('updateData', { key: 'errorMessage', value: 'Error saving link' })
             commit('updateData', { key: 'savedLink', value: true })
           }