Skip to content

Commit

Permalink
Fix deprecated API from Python 3.7 (#189)
Browse files Browse the repository at this point in the history
This revision updates pybind11 commit to the recent one which fixes Python 3.7 API break due to deprecation. Since this has been warned at least since 3.6, even targeting 3.6 will prevent building Jet Framework (due to `-Werror`). This has been found by building Jet from the latest Miniconda environment.

In addition to the commit ID bump, latest pybind11 also deprecates the use of PYBIND11_PLUGIN. Thus, this diff also fixes that issue as well.
  • Loading branch information
doyubkim committed Aug 24, 2018
1 parent e7e784d commit e67980f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion external/pybind11
Submodule pybind11 updated 169 files
8 changes: 2 additions & 6 deletions src/python/main.cpp
Expand Up @@ -100,10 +100,8 @@

namespace py = pybind11;

PYBIND11_PLUGIN(pyjet) {
py::module m("pyjet", R"pbdoc(
Fluid simulation engine for computer graphics applications
)pbdoc");
PYBIND11_MODULE(pyjet, m) {
m.doc() = "Fluid simulation engine for computer graphics applications";

// Constants
addConstants(m);
Expand Down Expand Up @@ -312,6 +310,4 @@ PYBIND11_PLUGIN(pyjet) {
#else
m.attr("__version__") = py::str("dev");
#endif

return m.ptr();
}

0 comments on commit e67980f

Please sign in to comment.