Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix grpc proxy wrapper modify binder #1094

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

linthan
Copy link
Member

@linthan linthan commented Apr 24, 2024

Describe what this PR does / why we need it

don't modify the default binder of echo server

Does this pull request fix one issue?

changing default binder of echo server will cause the problem that some controllers cannot get the query params .

Describe how you did it

1 request a grpc proxy wrapper controller
2 request a normal get controller
3 the normal controller cannot get the correct query param

Describe how to verify it

Special notes for reviews

@hjxp hjxp changed the title bug: fix grpc proxy wrapper modify binder fix: fix grpc proxy wrapper modify binder May 11, 2024
@sysulq
Copy link
Member

sysulq commented May 13, 2024

@dependabot rebase

@sysulq sysulq merged commit d967017 into douyu:master May 17, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants