Sanitizer fixes #127
Merged
Sanitizer fixes #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake option ENKITS_SANITIZE Added ENKITS_SANITIZE to workflow static builds
|
I'll look into this shortly - the CMake and actions changes add a few extra things to review so it will take a bit of time. Note that thread sanitizer currently throws up some false reports when in the tests, so I don't want to add it to the github actions. I could reconfigure the test so these false reports don't get triggered, but that will take a bit of time which I don't currently have. |
|
Merged, thanks once again! |
|
Thanks! I'll look into thread sanitizer more later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake option ENKITS_SANITIZE
Added ENKITS_SANITIZE to workflow static builds
Later it would be good to hookup thread sanitizer as well.
There was a problem getting the Windows runner to find the asan dll. I found a fix here: actions/runner-images#8891