feat: volume fade in/out #2121
Open
feat: volume fade in/out #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ba3afe4.
…t-native-track-player into dev-android-auto
feat: full android auto support
feat: RemoteSkip
chore: sync up main
|
I'd love to see this get submitted into 4.1.0 — @dcvz do you think that's possible? |
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
bump
…On Mon, Jan 29, 2024, 5:48 PM github-actions[bot] ***@***.***> wrote:
This PR is stale because it has been open 90 days with no activity. Remove
stale label or comment or this will be closed in 7 days.
—
Reply to this email directly, view it on GitHub
<#2121 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZMOVVXBF52PJUV3WZMI57LYRBGP7AVCNFSM6AAAAAA4RN75ASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVHEYTINZZGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
…ck-player into dev-fadeinout
…ck-player into dev-fadeinout
…ck-player into dev-fadeinout
…ck-player into dev-fadeinout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds volume fade in/out effect.
on not android platforms this is done by using Animated.Value. I do not have iOS to test but it seems like iOS doesn't have a background react rendering problem that this should work.
on android this is done by using doublesymmetry/KotlinAudio#91. because Animated.Value doesnt update within HeadlessJsTaskService I added a simple linear fading function for it.
kotlin's scope.async doesn't work as I expected (Deferred.await() doesn't wait for RN's Promise.resolve?) any help is appreciated! because of this I cannot reliably await for the volume fading change to complete, so I used event emitting and handle the callback function within that event emitting, which is quite unnecessarily complicated, compared to a simple callback function in Animated.Timing.Start().