add DynamicTokenProvider. #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 29, 2022 18:37
Signed-off-by: Vicente Yu <^@^>
Signed-off-by: Vicente.Yu <^@^>
Signed-off-by: Vicente.Yu <^@^>
EzrealJ
reviewed
Nov 21, 2023
There was a problem hiding this comment.
IgnoreAttribute可以和WDynamicTokenAttribute合并，参考HeaderAttribute
EzrealJ
reviewed
Nov 21, 2023
| /// </summary> | ||
| /// <param name="serviceProvider">服务提供者</param> | ||
| /// <returns></returns> | ||
| protected abstract Task<TokenResult?> RequestTokenAsync(IServiceProvider serviceProvider); |
There was a problem hiding this comment.
RequestTokenAsync可能需要携带identifier参数
EzrealJ
reviewed
Nov 21, 2023
| /// <param name="serviceProvider">服务提供者</param> | ||
| /// <param name="refresh_token">刷新token</param> | ||
| /// <returns></returns> | ||
| protected abstract Task<TokenResult?> RefreshTokenAsync(IServiceProvider serviceProvider, string refresh_token); |
There was a problem hiding this comment.
RefreshTokenAsync可能需要携带identifier参数？
There was a problem hiding this comment.
RefreshTokenAsync 按理不用，是以token换token。
|
这个接口的设计，与原体系偏离了，没有能够利用起ITokenProviderFactory的功能。 |
懂了懂了，感谢！ |
added 9 commits
November 22, 2023 18:22
Signed-off-by: Vicente.Yu <^@^>
Signed-off-by: Vicente.Yu <^@^>
Signed-off-by: Vicente.Yu <^@^>
Signed-off-by: Vicente.Yu <^@^>
Signed-off-by: Vicente.Yu <^@^>
Signed-off-by: Vicente.Yu <^@^>
Signed-off-by: Vicente.Yu <^@^>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
多个应用，共享一套api 的TokenProvider机制。