Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ProcessPicker via resolveDebugConfiguration #4509

Merged
merged 4 commits into from Apr 21, 2021

Commits on Apr 20, 2021

  1. Handle ProcessPicker via resolveDebugConfiguration

    VS Code commands are limited to only being able to have a single output.
    We will handle having an empty processId and show the dialog for
    ProcessPicker in resolveDebugConfigurationWithSubstitutedVariables.
    We need multiple outputs to handle the latest macOS on Apple M1.
    
    For Apple Silicon M1 (ARM64), we need to determine if we need to use the
    x86_64 or arm64 debugger. We are able to detect if the process is using
    S_TRANSLATED using the ps commandline with 'flags', if it is set with
    0x20000, it is emulated.
    WardenGnaw committed Apr 20, 2021
    Copy the full SHA
    4bfd862 View commit details
    Browse the repository at this point in the history
  2. Addressing PR issues

    Migrate remoteProcessPicker to also be in resolve configuration
    
    Handle 'clr' type for remote process picking.
    
    Addressing PR issues.
    
    Added comment about 0x20000
    WardenGnaw committed Apr 20, 2021
    Copy the full SHA
    4a72d1d View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    93f562c View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    2a17228 View commit details
    Browse the repository at this point in the history