Add JsonNumberHandling(Attribute) & support for (de)serializing numbers from/to string #39363

layomia · 2020-07-15T16:05:12Z

Dotnet-GitSync-Bot · 2020-07-15T16:05:16Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs

...aries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/Int64Converter.cs

...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/ByteConverter.cs

src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.String.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs

src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonNumberHandling.cs

src/libraries/System.Text.Json/src/System/Text/Json/Reader/JsonReaderHelper.cs

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs

...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/ByteConverter.cs

…string

src/libraries/System.Text.Json/tests/Serialization/Object.ReadTests.cs

src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs

steveharter

From other pending changes per offline review, LGTM.

layomia · 2020-07-21T01:28:03Z

Barring benchmark noise, there are no noticeable perf regressions caused by this PR:

dotnet run --base D:\benchmarks\numbers\master --diff D:\benchmarks\numbers\feature --threshold 2%
summary:
better: 4, geomean: 1.039
worse: 4, geomean: 1.034
total diff: 8

Slower	diff/base	Base Median (ns)	Diff Median (ns)
System.Text.Json.Serialization.Tests.ReadJson.DeserializeFromUtf8Bytes	1.04	81.42	85.00
System.Text.Json.Serialization.Tests.WriteJson.SerializeToUtf8Bytes	1.04	15760.37	16318.96
System.Text.Json.Serialization.Tests.WriteJson.SerializeToUtf8By	1.03	318.62	328.68
System.Text.Json.Serialization.Tests.WriteJson.SerializeToUtf8Bytes	1.03	120.47	123.72

Faster	base/diff	Base Median (ns)	Diff Median (ns)
System.Text.Json.Serialization.Tests.WriteJson.SerializeToUtf8Bytes	1.04	416.34	400.33
System.Text.Json.Serialization.Tests.WriteJson.Serializ	1.04	462715.53	445168.06
System.Text.Json.Serialization.Tests.WriteJson.SerializeToUtf8Bytes	1.04	808.07	778.40
System.Text.Json.Serialization.Tests.ReadJson.Deseri	1.04	304.35	293.22

feature.zip
master.zip

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs

.../System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/IListConverter.cs

...ystem.Text.Json/src/System/Text/Json/Serialization/Attributes/JsonNumberHandlingAttribute.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonNumberHandling.cs

...libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Helpers.cs

src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs

…rs from/to string (dotnet#39363) * Add JsonNumberHandling & support for (de)serializing numbers from/to string * Add JsonNumberHandlingAttribute * Address review feedback + fixups * Address review feedback ii

src/libraries/System.Text.Json/src/System/Text/Json/JsonConstants.cs

src/libraries/System.Text.Json/src/System/Text/Json/Reader/JsonReaderHelper.cs

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs

src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs

layomia added the area-System.Text.Json label Jul 15, 2020

layomia added this to the 5.0.0 milestone Jul 15, 2020

layomia requested review from steveharter and Jozkee July 15, 2020 16:05

layomia self-assigned this Jul 15, 2020

Dotnet-GitSync-Bot added the new-api-needs-documentation label Jul 15, 2020

Jozkee reviewed Jul 15, 2020

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs Outdated Show resolved Hide resolved

layomia force-pushed the json_number branch 3 times, most recently from bfb01c9 to 29d317f Compare July 15, 2020 17:20

steveharter reviewed Jul 15, 2020

View reviewed changes

...aries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/Int64Converter.cs Outdated Show resolved Hide resolved

Jozkee reviewed Jul 15, 2020

View reviewed changes

steveharter reviewed Jul 16, 2020

View reviewed changes

src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs Outdated Show resolved Hide resolved

steveharter reviewed Jul 16, 2020

View reviewed changes

src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs Show resolved Hide resolved

steveharter reviewed Jul 16, 2020

View reviewed changes

src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs Outdated Show resolved Hide resolved

steveharter reviewed Jul 16, 2020

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonNumberHandling.cs Outdated Show resolved Hide resolved

steveharter reviewed Jul 16, 2020

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Reader/JsonReaderHelper.cs Outdated Show resolved Hide resolved

steveharter reviewed Jul 16, 2020

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs Show resolved Hide resolved

steveharter reviewed Jul 16, 2020

View reviewed changes

...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/ByteConverter.cs Outdated Show resolved Hide resolved

layomia force-pushed the json_number branch from 29d317f to 1d7a438 Compare July 19, 2020 01:34

layomia changed the title ~~Add JsonNumberHandling & support for (de)serializing numbers from/to string~~ Add JsonNumberHandling(Attribute) & support for (de)serializing numbers from/to string Jul 19, 2020

layomia added 2 commits July 19, 2020 11:45

Add JsonNumberHandling & support for (de)serializing numbers from/to …

b8c4563

…string

Add JsonNumberHandlingAttribute

dac0e6a

layomia force-pushed the json_number branch 6 times, most recently from 51b8044 to 3b90de7 Compare July 20, 2020 08:47

layomia force-pushed the json_number branch from e32d7a5 to 238810a Compare July 20, 2020 19:55

Address review feedback + fixups

8385f18

layomia force-pushed the json_number branch from 238810a to 8385f18 Compare July 20, 2020 21:15