Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build to net9.0 images #101630

Merged
merged 5 commits into from Apr 28, 2024
Merged

Update build to net9.0 images #101630

merged 5 commits into from Apr 28, 2024

Conversation

richlander
Copy link
Member

@richlander richlander commented Apr 26, 2024

This change will update the branch to building with LLVM 18.1.4. Everything else should be the same relative to the net8.0 image flavor (which we intend to apply to release/8.0 branch in July or so).

dotnet/dotnet-buildtools-prereqs-docker#1015

@sbomer

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@richlander
Copy link
Member Author

Looks like the x86 build has a failure with the new compiler. Reverting that for now. We'll need to deal with that in a separate focused PR. Other architectures appear to be fine.

  /__w/1/s/src/coreclr/pal/inc/pal.h:3605:5: error: __sync builtin operation MUST have natural alignment (consider using __atomic). [-Werror,-Wsync-alignment]
   3605 |     __sync_val_compare_and_swap(
        |     ^
  /__w/1/s/src/coreclr/pal/inc/pal.h:3471:5: error: __sync builtin operation MUST have natural alignment (consider using __atomic). [-Werror,-Wsync-alignment]
   3471 |     __sync_add_and_fetch(lpAddend, (LONGLONG)1)
        |     ^
  /__w/1/s/src/coreclr/pal/inc/pal.h:3506:5: error: __sync builtin operation MUST have natural alignment (consider using __atomic). [-Werror,-Wsync-alignment]
   3506 |     __sync_sub_and_fetch(lpAddend, (LONGLONG)1)
        |     ^
  3 errors generated.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=657718&view=logs&j=3e76e48d-899b-5193-2f21-2a0f6c53e9ff&t=a2c05d5c-b239-5644-4717-b3f9c339267b&l=752

@richlander
Copy link
Member Author

@lewing do you think the wasm failures are related to this change?

@jkotas
Copy link
Member

jkotas commented Apr 28, 2024

The wasm failures are know issues.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit 6313ff8 into dotnet:main Apr 28, 2024
145 of 150 checks passed
@richlander richlander deleted the azurelinux-net9.0 branch April 28, 2024 15:03
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
* Update build to `net9.0` images

* Update docs/workflow/building/coreclr/linux-instructions.md

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

* Revert x86 build change

---------

Co-authored-by: Sven Boemer <sbomer@gmail.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
* Update build to `net9.0` images

* Update docs/workflow/building/coreclr/linux-instructions.md

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>

* Revert x86 build change

---------

Co-authored-by: Sven Boemer <sbomer@gmail.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants