Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.8] Migrate official builds to 1ES template #73210

Merged
merged 6 commits into from
Apr 24, 2024
Merged

[17.8] Migrate official builds to 1ES template #73210

merged 6 commits into from
Apr 24, 2024

Conversation

jjonescz
Copy link
Contributor

@jjonescz jjonescz commented Apr 24, 2024 •
edited

dotnet-maestro bot and others added 3 commits April 24, 2024 08:11
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
605be07 
…404.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23461.2 -> To Version 8.0.0-beta.24204.3

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23475.1 (parent: Microsoft.DotNet.Arcade.Sdk
@jjonescz
Revert SDK change
e64d364
@jjonescz
Update source build baseline
422cce0
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 24, 2024
@jjonescz jjonescz marked this pull request as ready for review April 24, 2024 11:51
@jjonescz jjonescz requested review from a team as code owners April 24, 2024 11:51
@jjonescz jjonescz requested a review from jaredpar April 24, 2024 12:42
mthalman
mthalman approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source build baseline changes look good.

@jaredpar jaredpar merged commit 79940f1 into dotnet:release/dev17.8 Apr 24, 2024
22 of 27 checks passed
@build-analysis build-analysis bot mentioned this pull request Apr 24, 2024
Open
3 tasks
@jjonescz jjonescz deleted the 1es-pt-17.8 branch April 24, 2024 16:07
@jjonescz jjonescz mentioned this pull request Apr 25, 2024
Merged
@mmitche
Copy link
Member

mmitche commented Apr 26, 2024

Agreed on sb baseline updates being fine.

@jjonescz jjonescz mentioned this pull request May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jjonescz @mmitche @jaredpar @mthalman