Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support implementing multiple IConverter<,> in single converter class #8881

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support implementing multiple IConverter<,> in single converter class #8881

wants to merge 4 commits into from
+88 −1

Commits on Mar 7, 2024

  1. Added failing ICopier unit test 

    - When declaring a single converter class for multiple surrogates,
  ICopier will always resolve the last declared IConverter<,> interface,
  failing with a InvalidCastException at runtime
    @ccorsano @ReubenBond
    ccorsano authored and ReubenBond committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    499f6d3 View commit details
    Browse the repository at this point in the history

  2. Completed failing ICopier unit test 

    - Added Equals and GetHashCode to foreign types
    @ccorsano @ReubenBond
    ccorsano authored and ReubenBond committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    2c2dd1d View commit details
    Browse the repository at this point in the history

  3. Support multiple IConverter<,> in surrogate converter class 

    - Only resolves IConverter<,> interface matching foreign type
    @ccorsano @ReubenBond
    ccorsano authored and ReubenBond committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    78fff92 View commit details
    Browse the repository at this point in the history

  4. Switch to a stricter type equality check

    @ccorsano @ReubenBond
    ccorsano authored and ReubenBond committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    778cb54 View commit details
    Browse the repository at this point in the history