Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PointerGestureHandler not registering touches on android #22109

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix PointerGestureHandler not registering touches on android #22109

wants to merge 2 commits into from
+35 −1

Conversation

mrmrmystery
Copy link

Description of Change

Added TouchListener to the PointerGestureHandler

Issues Fixed

Touch interactions now also trigger the PointerGestureHandler events

Fixes #20849

@mrmrmystery mrmrmystery requested a review from a team as a code owner April 28, 2024 21:31
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 28, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @mrmrmystery! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@mrmrmystery
Copy link
Author

@dotnet-policy-service agree

@PureWeen
Copy link
Member

Do all the Pointer Gesture events fire when using a touch screen on Windows?

Doesn't this create overlap between the TapGestureREcognizer and PointerGestureRecognizer?

Pointer was primarily meant for hardware input device interactions (mice).

Can you use the new TouchEffect from MCT?
CommunityToolkit/Maui#86

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz jsuarezruiz added the area-gestures Gesture types label Apr 29, 2024
jsuarezruiz
jsuarezruiz reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some UI Tests related with gestures (tap, double tap) failing:
image
For example, DoubleTap:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

@Eilon Eilon Awaiting requested review from Eilon Eilon is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-gestures Gesture types community ✨ Community Contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PointerGestureRecognizer Does Not Work on Android
3 participants
@mrmrmystery @PureWeen @jsuarezruiz