[ios/catalyst] fix memory leak in modal pages #22089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
added
platform/iOS 🍎
memory-leak 💦
jonathanpeppers
force-pushed
the
ModalPageLeaks
branch
from
503e2d6
to
bd07027
Compare
Fixes: dotnet#20094 Context: https://github.com/AdamEssenmacher/iOSModalLeak.Maui In the above sample, you can see that modal `Page`'s on iOS or Catalyst live forever after they are dismissed. I was able to reproduce this issue in a device test. After some investigation, the `ContainerViewController` appears to have a cycle: * `ContainerViewController` -> `IElement? _view;` -> `PageHandler` -> `ContainerViewController After 7d0af63 was merged, this works fine when using `NavigationPage`, but not when using modals. It appears after solving the cycle, the `ContainerViewController` goes away as well as the `PageHandler` and the `Page`.
jonathanpeppers
force-pushed
the
ModalPageLeaks
branch
from
bd07027
to
ec3d854
Compare
jsuarezruiz
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20094
Context: https://github.com/AdamEssenmacher/iOSModalLeak.Maui
In the above sample, you can see that modal
Page's on iOS or Catalyst live forever after they are dismissed. I was able to reproduce this issue in a device test.After some investigation, the
ContainerViewControllerappears to have a cycle:ContainerViewController->IElement? _view;->PageHandler->ContainerViewControllerAfter 7d0af63 was merged, this works fine when using
NavigationPage, but not when using modals.It appears after solving the cycle, the
ContainerViewControllergoes away as well as thePageHandlerand thePage.