[X] do not apply Bindings if DataType doesnt match #22056
+91
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
force-pushed
the
fix_xDataType
branch
2 times, most recently
from
cdef2e5
to
f0d623a
Compare
PureWeen
requested review from
Redth,
simonrozsival and
mattleibow
and removed request for
Eilon and
tj-devel709
| var bindingContext = src ?? Context ?? context; | ||
| if (DataType != null && bindingContext != null && !DataType.IsAssignableFrom(bindingContext.GetType())) | ||
| { | ||
| bindingContext = null; |
There was a problem hiding this comment.
Should we log a warning to make it easier to debug the type mismatch?
There was a problem hiding this comment.
I'm afraid that a warning will make HotReload fail
Comment on lines
+31
to
+32
| if (node is IElementNode elementNode) | ||
| Add(typeof(IXamlDataTypeProvider), new XamlDataTypeProvider(elementNode)); |
There was a problem hiding this comment.
Will this service be added even when XamlC creates the new XamlServiceProvider instance? And if it is, won't this be added for almost any extension, even if IXamlDataTypeProvider is not in its [RequiredService([...])]?
There was a problem hiding this comment.
going to fix this
There was a problem hiding this comment.
RequiredService isn't in main yet. also, this won't get invoked from compiled XAML
Make sure the behavior of bindings is consistent accross implementations (compiled/not compiled) fixes a bunch of issues
StephaneDelcroix
force-pushed
the
fix_xDataType
branch
from
f0d623a
to
18a2881
Compare
simonrozsival
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Make sure the behavior of bindings is consistent accross implementations (compiled/not compiled)
fixes a bunch of issues
Issues Fixed