Fixed creation of the CustomTabsActivityManager #22018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @koviant! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
PureWeen
requested review from
Redth and
mattleibow
and removed request for
Eilon and
StephaneDelcroix
jsuarezruiz
added
the
area-essentials
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix to avoid using the
Frommethod to get the CustomTabsActivityManager manager. This method would store a reference to the activity from a static field, and this will be kept after activity is destroyed. As no extra logic is inside this method, I've changed it to direct new instance creation each time.Issues Fixed
Fixes #22017