Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converters to DatePicker and TimePicker for DateOnly and TimeOnly #21989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

symbiogenesis
Copy link
Contributor

I realize that full DateOnly and TimeOnly support is not implemented yet. This is a start in that direction.

Fixes #20438

As mentioned in the comments there, fixing that bug is merely a subset of #1100 which can be fixed without the need for a full implementation.

@symbiogenesis symbiogenesis requested a review from a team as a code owner April 23, 2024 03:13
Copy link
Contributor

Hey there @symbiogenesis! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 23, 2024
@symbiogenesis symbiogenesis changed the title Add converters to DatePicker and TimePicker for DateOnly and TimeOnly, respectively Add converters to DatePicker and TimePicker for DateOnly and TimeOnly Apr 23, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

@jsuarezruiz jsuarezruiz added the t/enhancement ☀️ New feature or request label Apr 23, 2024
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Apr 26, 2024
@jsuarezruiz
Copy link
Contributor

There are some compilation errors:

D:\a\_work\1\s\src\Controls\src\Core\TimePicker\TimePicker.cs(71,47): error CS0246: The type or namespace name 'TimeOnlyConverter' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net8.0-windows10.0.19041.0]

@Eilon Eilon added area-controls-datetimepicker DatePicker, TimePicker and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-datetimepicker DatePicker, TimePicker community ✨ Community Contribution t/enhancement ☀️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XAML DatePicker Control Does Not Update DateOnly Items
3 participants