[Android] Entry & Picker VerticalTextAlignment ignored #21966
+100
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
jsuarezruiz
added
platform/android 🤖
area-controls-entry
|
Azure Pipelines successfully started running 3 pipeline(s). |
dotnet-policy-service
bot
added
the
legacy-area-controls
jsuarezruiz
requested changes
Apr 22, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
reviewed
Apr 23, 2024
| { | ||
| if (PlatformView != null && VirtualView != null) | ||
| { | ||
| PlatformView.SetHeight(PlatformView.Height); |
There was a problem hiding this comment.
Not sure I understand what this line is doing?
There was a problem hiding this comment.
Yes, this is a strange one, but it fixes it. For some reason, these heights have different values
| if (PlatformView != null && VirtualView != null) | ||
| { | ||
| PlatformView.SetHeight(PlatformView.Height); | ||
| PlatformView.UpdateVerticalTextAlignment(VirtualView); |
There was a problem hiding this comment.
Instead of calling the Update directly, can you rather invoke the mapper? This way if someone overrides the mapper, their code still gets called.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Eilon
removed
the
legacy-area-controls
|
Updated test snapshot. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #21717