Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove custom .ipynb handling and update apis #1295

Merged
merged 4 commits into from Apr 23, 2021

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Apr 22, 2021

Remove all custom Jupyter/.ipynb handling. The default new notebook is still .ipynb until microsoft/vscode#121974 is fixed, but then we'll default to .dib.

Scenarios to validate in Insiders:

  1. Double-click existing .NET .ipynb; our controller should be selected and cell languages should be correct. Our controller is properly selected based on our specified affinity, but due to onDidChangeNotebookAssociation not fired on initial notebook open microsoft/vscode#121904 the cell languages aren't yet correct. There is currently no workaround.
  2. Double-click existing .dib; everything should work as before. This is good.
  3. New Jupyter notebook, select one of our languages. Our kernel controller should be selected. Our controller is properly selected, but again, due to onDidChangeNotebookAssociation not fired on initial notebook open microsoft/vscode#121904 the cell languages aren't yet correct.

@brettfo brettfo marked this pull request as draft April 22, 2021 23:14
@brettfo brettfo changed the title [WIP] remove custom .ipynb handling and update apis remove custom .ipynb handling and update apis Apr 23, 2021
@brettfo brettfo marked this pull request as ready for review April 23, 2021 01:48
@colombod
Copy link
Member

colombod commented Apr 23, 2021

in my environment I don't have python extension so our controller is the only option
So far:

  1. open dib works
  2. new blank notebook using the command Jupyter : create new blank notebook selects our controller but languages are wrong
  3. open ipynb our controller is selected but languages are wrong
  4. new blank notebook using the command .NET Interactive : create new blank notebook selects our controller but languages are wrong
  5. Can't close a dib with pending changes
  6. Can't set a notebook to trusted

@colombod
Copy link
Member

Our notebook handling setting medatada on cells when working with dib files makes the document dirty and that causes the infinite loop of reopen when closing a dirty document even discarding the edits, the document seems to be modified and vscode will reopen

@colombod colombod mentioned this pull request Apr 23, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants