Add constraints for ^Step param type in ranges in (.. ..) operators
#17133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
abelbraaksma
force-pushed
the
ranges-with-step-constraints
branch
from
539ba22
to
05f1282
Compare
abelbraaksma
added
Area-Library
abelbraaksma
force-pushed
the
ranges-with-step-constraints
branch
from
37f207d
to
93223e4
Compare
Fixes dotnet#6238. Compiler does not infer this automatically through `and default`.
abelbraaksma
force-pushed
the
ranges-with-step-constraints
branch
from
93223e4
to
9775798
Compare
abelbraaksma
force-pushed
the
ranges-with-step-constraints
branch
from
9775798
to
3ef8255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using user-defined types with ranges (that is, the
.. ..operator as infor x in y .. step .. z doand the like) are required to havecomparisonandequalityconstraints. While the definition of(.. ..)has these constraints on the counter type, and it hasand default ^Step : ^T, the compiler does not infer from this that this requires the^Stepparameter to have the same constraints.This should be caught by the compiler as a discrepancy between the
*.fsifile and the implementation file.Without using the constraints on your type, code would compile, but always fail at runtime. See linked issue for details.
Fixes #6238
Checklist